williaster commented on a change in pull request #3993: [Explore view] Use POST
method for charting requests
URL:
https://github.com/apache/incubator-superset/pull/3993#discussion_r161938807
##########
File path: superset/assets/javascripts/explore/exploreUtils.js
##########
@@ -65,5 +93,33 @@ export function getExploreUrl(form_data, endpointType =
'base', force = false,
});
}
uri = uri.search(search).directory(directory);
- return uri.toString();
+ const payload = { ...formData };
+
+ return {
+ url: uri.toString(),
+ payload,
+ };
+}
+
+export function exportChart(formData, endpointType) {
Review comment:
seems like a mix of positional + named in this PR, big fan of consistently
using the latter (which is used in `getExploreUrlAndPayload` for instance) but
not a blocker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
