[
https://issues.apache.org/jira/browse/SYNCOPE-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539242#comment-13539242
]
Francesco Chicchiriccò commented on SYNCOPE-241:
------------------------------------------------
Hi Christian, I've just checked your patch and found the following issues:
1. I have some garbage with SyncActions (this is due to the fact that you
submitted your patch just before I was about to commit some modifications for
SYNCOPE-26)
2. persistence-api/pom.xml seems a bit "redunant" to me: too many dependencies
are there, you should try to fit with the bare minimum required
3. the openjpa-maven-plugin used in persistence-api/pom-xml is an archaic
version 1.2, while currently core/pom.xml is using the one aligned with the
OpenJPA version (2.2.1)
4. you should also check if core/pom.xml can be slimmed down in terms of
dependencies injected by persistence-api/pom.xml
5. being forced to list all persistence entities under
core/src/main/resources/META-INF/spring-persistence.xml is bad - core is
currently using Spring to dynamically inject this
6. there is no need to have
persistence-api/src/main/resources/META-INF/persistence-enhance.xml as part of
the persistence-api JAR artifact, since, AFAIU this is used only for the class
enhancement
7. one of advantages reported in the description is that 'the persistence tests
could run in the persistence impl module', but I don't see this in the patch
Regards.
> Move persistence and persistence impl into separate modules
> -----------------------------------------------------------
>
> Key: SYNCOPE-241
> URL: https://issues.apache.org/jira/browse/SYNCOPE-241
> Project: Syncope
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.0.3-incubating
> Reporter: Christian Schneider
> Fix For: 1.1.0
>
> Attachments: SYNCOPE-241-2.patch, SYNCOPE-241.patch
>
>
> The core module currently contains many parts of syncope. This makes it
> bigger and more complex than necessary.
> A possible modularization is to move the internal model
> (org.apache.syncope.core.persistence*) and the persistence impl
> (org.apache.syncope.core.persistence.impl) out of core and into separate
> modules.
> One big advantage would be that the jpa code enhancements would then run in
> the model module only. Currently we run into some problems in the cxf
> migration when running the rest itests in core that may be caused by eclipse
> overwriting the enhanced classes with plain classes. If the model
> (peristence) classes are in a separate module we could leave it out of
> eclipse and so this would be no issue anymore.
> Another advantage would be that the persistence tests could run in the
> persistence impl module so when working on the core they would not have to
> run each time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
