[ 
https://issues.apache.org/jira/browse/SYNCOPE-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539250#comment-13539250
 ] 

Francesco Chicchiriccò commented on SYNCOPE-241:
------------------------------------------------

About the item (5), take a look at core's persistenceContext.xml and 
persistenceContextEMFactory.xml

The db profiles actually need to stay in both submodules (core and 
persistence-api) so that testing is more complete: consider that unit tests are 
not really able to check all transactional-related aspects. We had many 
troubles in the past (especially with Oracle and PostgreSQL) about this aspect.

Finally, when you need to move some implementation classes (*DAOImpl, for 
example) in order to run tests, I'd rather name the new module 'persistence' 
and not 'persistence-api'.
                
> Move persistence and persistence impl into separate modules
> -----------------------------------------------------------
>
>                 Key: SYNCOPE-241
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-241
>             Project: Syncope
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.0.3-incubating
>            Reporter: Christian Schneider
>             Fix For: 1.1.0
>
>         Attachments: SYNCOPE-241-2.patch, SYNCOPE-241.patch
>
>
> The core module currently contains many parts of syncope. This makes it 
> bigger and more complex than necessary.
> A possible modularization is to move the internal model 
> (org.apache.syncope.core.persistence*) and the persistence impl 
> (org.apache.syncope.core.persistence.impl) out of core and into separate 
> modules.
> One big advantage would be that the jpa code enhancements would then run in 
> the model module only. Currently we run into some problems in the cxf 
> migration when running the rest itests in core that may be caused by eclipse 
> overwriting the enhanced classes with plain classes. If the model 
> (peristence) classes are in a separate module we could leave it out of 
> eclipse and so this would be no issue anymore.
> Another advantage would be that the persistence tests could run in the 
> persistence impl module so when working on the core they would not have to 
> run each time. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to