[
https://issues.apache.org/jira/browse/SYNCOPE-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552534#comment-13552534
]
Christian Schneider commented on SYNCOPE-241:
---------------------------------------------
1. I removed the commented out entries. I chose the name as the context is
there for the persistence tests. Do you have a better idea how to name it?
2. Removed these
3. I checked the code of loadXml and indeed there are cases where it does not
close the inputStream. I added safe close calls to all occurences
4. I removed the ones I found
5. I removed the interfaces for PasswordPolicyEnforcer and
AccountPolicyEnforcer as they were indeed only used there. You proposed to
consolidate the implementation in AccountPolicyEnforcerImpl. I think this is
not possible as the implementation uses classes outside the persistence
packages I prepared. Of course we could add these packages but then we would
soon end with the whole core in there
6. Renamed the classes
> Move persistence and persistence impl into separate modules
> -----------------------------------------------------------
>
> Key: SYNCOPE-241
> URL: https://issues.apache.org/jira/browse/SYNCOPE-241
> Project: Syncope
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.0.3-incubating
> Reporter: Christian Schneider
> Fix For: 1.1.0
>
> Attachments: SYNCOPE-241-2.patch, SYNCOPE-241-3.patch,
> SYNCOPE-241-4.patch, SYNCOPE-241.patch
>
>
> The core module currently contains many parts of syncope. This makes it
> bigger and more complex than necessary.
> A possible modularization is to move the internal model
> (org.apache.syncope.core.persistence*) and the persistence impl
> (org.apache.syncope.core.persistence.impl) out of core and into separate
> modules.
> One big advantage would be that the jpa code enhancements would then run in
> the model module only. Currently we run into some problems in the cxf
> migration when running the rest itests in core that may be caused by eclipse
> overwriting the enhanced classes with plain classes. If the model
> (peristence) classes are in a separate module we could leave it out of
> eclipse and so this would be no issue anymore.
> Another advantage would be that the persistence tests could run in the
> persistence impl module so when working on the core they would not have to
> run each time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
