nirvanjhurreepriv commented on PR #2524: URL: https://github.com/apache/systemds/pull/2524#issuecomment-5058384295
Also @ywcb00 , two things I should have added: I can't run the federated tests locally (Java 21 dropped Subject.getSubject, which Hadoop 3.3.6 still calls), so the error bounds are worked out on paper with some headroom rather than measured; if one turns out too tight on CI I'll loosen it. Also, bumping the dimensions surfaced a bug in the DML: it was building B from $rows instead of $cols, which only worked because the old parameters happened to have rows equal to cols. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
