ywcb00 commented on PR #2524: URL: https://github.com/apache/systemds/pull/2524#issuecomment-5070976768
Try to keep the tests consistent with the general structure of other federated tests: - Use the functions that are provided by our automated test base for common functionality (e.g., creating random matrix) rather than implementing your own functions for this. - Use random matrices for the tests. - Consider using more than one federated worker. - Create the federated matrix inside the test script (simlar to `FederatedReference.dml`; or is there a reason why you have changed this in commit 5fc676de0fa52b8385e7b08321de209094525baf?). Currently, both your test script and your reference script are identical. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
