nirvanjhurreepriv commented on PR #2524: URL: https://github.com/apache/systemds/pull/2524#issuecomment-5078646431
Hi @ywcb00, Thanks for the feedback. Regarding the commit: when the federated run threw an "unknown host" error I switched it to `read()`, which made the error go away but ended up making both scripts identical. I'll fix all four points: use `getRandomMatrix` from the base class, use random matrices, run with one and two workers like `FederatedReaderTest`, and restore `federated()` in the test script so it's no longer the same as the reference. One quick question before I rework it. The compression happens in `FederationMap.broadcast()`, which compresses the *local* matrix that gets sent to the workers, not the federated matrix, which stays on the workers. So in `Z = X %*% B` with `X` federated, it's `B` that actually gets compressed. Is that what you intended, or did you want the federated matrix itself to be sent compressed? Kind regards, Nirvan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
