ywcb00 commented on PR #2524: URL: https://github.com/apache/systemds/pull/2524#issuecomment-5107073633
I had a look at your latest changes @nirvanjhurreepriv. Here a few comments: - When adding additional code, please always make sure that the unit tests are covering the respective code parts. - Do not concatenate the matrix `X` manually with two `for` loops. - The test scripts are still identical. - Could you please explain the changes that you made to the reconstruction bound? Thanks and all the best, David -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
