[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791895#comment-13791895
]
Randy Abernethy commented on THRIFT-2205:
-----------------------------------------
Hey Henrique,
You give back a ton to this community, I appreciate your time whenever you
can spare it. Regarding the patch, I totally copped out when it came to the
integrating test but wanted to get the patch up in case someone needed
browser - node interop. I will try to find a minute this weekend to
integrate the node - browser test with the existing node integration tests.
This json server and the node bin one should of course share the same
handler. Back at you in a few days.
Best,
Randy
On Thu, Oct 10, 2013 at 11:57 AM, Henrique Mendonça (JIRA)
> Node.js Test Server to support test.js JavaScript Browser test and sundry
> fixes
> -------------------------------------------------------------------------------
>
> Key: THRIFT-2205
> URL: https://issues.apache.org/jira/browse/THRIFT-2205
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Library, Node.js - Library
> Affects Versions: 1.0
> Environment: All
> Reporter: Randy Abernethy
> Assignee: Randy Abernethy
> Priority: Minor
> Labels: node, nodejs
> Attachments:
> 0003-node-JSON-protocol-fixes-and-test-server-to-support-.patch
>
>
> Adds lib/nodejs/test/testsvr.js
> This server depends on ThriftTest[.js] and runs clean with test.js in the
> browser.
> Also in this patch:
> Repairs some shortfall in the Node JSON Protocol and transport. Fixes
> overflow on Javascript I64 tests. Improves static_server header output.
--
This message was sent by Atlassian JIRA
(v6.1#6144)