[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865618#comment-13865618
]
Henrique Mendonça commented on THRIFT-2205:
-------------------------------------------
Hi Randy,
Thanks so much for the contribution. I had a quick look and it seems like
you've ticked off many items of my TODO list :)
Unfortunately I really won't have time to test it properly in the next weeks
but if someone else can please feel free to do so and let us know. If you
rebase any patch you can also upload it next to the original one to save some
time.
@Pierre: it looks like there is some different solutions for some of your
patches, apart of THRIFT-2308 are you fine with Randy changes?
Cheers,
Henrique
> Node.js Test Server to support test.js JavaScript Browser test and sundry
> fixes
> -------------------------------------------------------------------------------
>
> Key: THRIFT-2205
> URL: https://issues.apache.org/jira/browse/THRIFT-2205
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Library, Node.js - Library
> Affects Versions: 1.0
> Environment: All
> Reporter: Randy Abernethy
> Assignee: Randy Abernethy
> Priority: Minor
> Labels: node, nodejs
> Attachments: 0002-repairs-Node-JSON-and-Buffer-and-adds-tests.patch
>
>
> Adds lib/nodejs/test/testsvr.js
> This server depends on ThriftTest[.js] and runs clean with test.js in the
> browser.
> Also in this patch:
> Repairs some shortfall in the Node JSON Protocol and transport. Fixes
> overflow on Javascript I64 tests. Improves static_server header output.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
