[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866469#comment-13866469
]
Randy Abernethy commented on THRIFT-2205:
-----------------------------------------
Hi Pierre,
There are a number of throw lines missing new:
multiplexed_processor.js: throw
Thrift.TException("TMultiplexedProcessor: Unexpected message type");
multiplexed_processor.js: throw
Thrift.TException("TMultiplexedProcessor: Unknown service: " + sname);
protocol.js: throw TProtocolException(BAD_VERSION, "Bad version in
readMessageBegin: " + sz);
protocol.js: throw TProtocolException(BAD_VERSION, "No protocol version
header");
protocol.js: throw Error("Invalid type: " + type);
transport.js: throw InputBufferUnderrunError;
transport.js: throw InputBufferUnderrunError;
Maybe easiest to add an additional patch to clean these up.
I didn't have any trouble applying the patch with git am when I tested it. If
it is not working for you let me know and I will retry it. The 0001 patch was a
throw away but was laying around when I made the final.
-Randy
> Node.js Test Server to support test.js JavaScript Browser test and sundry
> fixes
> -------------------------------------------------------------------------------
>
> Key: THRIFT-2205
> URL: https://issues.apache.org/jira/browse/THRIFT-2205
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Library, Node.js - Library
> Affects Versions: 1.0
> Environment: All
> Reporter: Randy Abernethy
> Assignee: Randy Abernethy
> Priority: Minor
> Labels: node, nodejs
> Attachments: 0002-repairs-Node-JSON-and-Buffer-and-adds-tests.patch
>
>
> Adds lib/nodejs/test/testsvr.js
> This server depends on ThriftTest[.js] and runs clean with test.js in the
> browser.
> Also in this patch:
> Repairs some shortfall in the Node JSON Protocol and transport. Fixes
> overflow on Javascript I64 tests. Improves static_server header output.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
