Hello Pierre, Good point. Any chance you can update your patch to apply over the 2205 patch and add a single bracket string test? If not I will try to update 2205 to apply over your patch later this week.
Best, Randy On Wed, Jan 8, 2014 at 1:54 AM, Pierre Lamot (JIRA) <[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865261#comment-13865261] > > Pierre Lamot commented on THRIFT-2205: > -------------------------------------- > > your algorithm to find the end of the json message in > TJSONProtocol.prototype.readMessageBegin is flawed, it will break if there > is a [ or ] within a string. for instance ["mystring]"]. > > see the patch I enclosed to > https://issues.apache.org/jira/browse/THRIFT-2308 > > Pierre > > > Node.js Test Server to support test.js JavaScript Browser test and > sundry fixes > > > ------------------------------------------------------------------------------- > > > > Key: THRIFT-2205 > > URL: https://issues.apache.org/jira/browse/THRIFT-2205 > > Project: Thrift > > Issue Type: Improvement > > Components: JavaScript - Library, Node.js - Library > > Affects Versions: 1.0 > > Environment: All > > Reporter: Randy Abernethy > > Assignee: Randy Abernethy > > Priority: Minor > > Labels: node, nodejs > > Attachments: > 0002-repairs-Node-JSON-and-Buffer-and-adds-tests.patch > > > > > > Adds lib/nodejs/test/testsvr.js > > This server depends on ThriftTest[.js] and runs clean with test.js in > the browser. > > Also in this patch: > > Repairs some shortfall in the Node JSON Protocol and transport. Fixes > overflow on Javascript I64 tests. Improves static_server header output. > > > > -- > This message was sent by Atlassian JIRA > (v6.1.5#6160) >
