[
https://issues.apache.org/jira/browse/TINKERPOP-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15824836#comment-15824836
]
ASF GitHub Bot commented on TINKERPOP-1601:
-------------------------------------------
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/535
TINKERPOP-1601 LazyBarrierStrategy should not check is.testing
https://issues.apache.org/jira/browse/TINKERPOP-1601
Only a minor improvement (strategies shouldn't behave differently depending
on whether we're in testing mode or not). If a test requires that certain
strategies don't do anything, then it's the test's job to exclude those
strategies.
`docker/build.sh -t -i` succeeded.
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1601
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/535.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #535
----
commit 0edf2e929b244055720d0e2054f21caef2205cc1
Author: Daniel Kuppitz <[email protected]>
Date: 2017-01-16T19:21:24Z
Removed IS_TESTING check from LazyBarrierStrategy.
commit 3179f6dab9065206a811e124c7827d4d9c5211ad
Author: Daniel Kuppitz <[email protected]>
Date: 2017-01-17T01:43:41Z
fixed assertion
commit ff844904df2b9e5d48c4725e8679f139c0e463e0
Author: Daniel Kuppitz <[email protected]>
Date: 2017-01-17T01:44:13Z
Changed btecode representation of excluded strategies to prevent
serialization issues.
----
> LazyBarrierStrategy should not check is.testing
> -----------------------------------------------
>
> Key: TINKERPOP-1601
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1601
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.3
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
>
> {{LazyBarrierStrategy}} should not check the value if the system variable
> {{is.testing}} and then behave differently depending on its value. The
> cleaner way is to just exclude {{LBS}} in {{ProfileTest}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
