[
https://issues.apache.org/jira/browse/TINKERPOP-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827925#comment-15827925
]
ASF GitHub Bot commented on TINKERPOP-1601:
-------------------------------------------
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/535
Either works, but I'm leaning more towards (a). I would do something like:
Assume the traversal:
`g.V().out().values('name').count()`
The test algorithm would:
1. If the first step is a `GraphStep` (instanceof), then make sure their is
a `ProfileStep` after it and that it has a traverser count of 6.
2. Find the next step that is an instanceof `VertexStep`. (if it doesn't
exist, oh well). Check subsequent `ProfileStep`.
3. Find the next step that is an instanceof `PropertiesStep`./ (if it
doesn't exist, oh well). Check subsequent `ProfileStep`.
4. etc.
In short, try and generalize as much as possible assuming that provider
strategies can wildly change the traversal.
Then in a `ProfileStrategyTest` you can do more what @rjbriody did in
`ProfileTest` as there you can isolate to single strategy application.
> LazyBarrierStrategy should not check is.testing
> -----------------------------------------------
>
> Key: TINKERPOP-1601
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1601
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.3
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
>
> {{LazyBarrierStrategy}} should not check the value if the system variable
> {{is.testing}} and then behave differently depending on its value. The
> cleaner way is to just exclude {{LBS}} in {{ProfileTest}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
