[
https://issues.apache.org/jira/browse/TINKERPOP-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826395#comment-15826395
]
ASF GitHub Bot commented on TINKERPOP-1601:
-------------------------------------------
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/535
I was thinking more about this specific problem. The real problem is
`ProfileTest`, not `LazyBarrierStrategy`. We need to generalize all the
`ProfileTest` test cases such that they not be concerned with particular
strategies -- as you are only solving for `LazyBarrierStrategy` (what about
provider specific strategies we have not (can not) consider). For instance, you
have the traversal prior to strategy application and post strategy application.
The tests should use the pre-strategy application to know the steps that should
have `ProfileSteps`.
> LazyBarrierStrategy should not check is.testing
> -----------------------------------------------
>
> Key: TINKERPOP-1601
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1601
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.3
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
>
> {{LazyBarrierStrategy}} should not check the value if the system variable
> {{is.testing}} and then behave differently depending on its value. The
> cleaner way is to just exclude {{LBS}} in {{ProfileTest}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
