[ 
https://issues.apache.org/jira/browse/TINKERPOP-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827900#comment-15827900
 ] 

ASF GitHub Bot commented on TINKERPOP-1601:
-------------------------------------------

Github user okram commented on the issue:

    https://github.com/apache/tinkerpop/pull/535
  
    This is not the way that this should be done. We shouldn't remove any 
strategies. What we should do is generalize the `ProfileTests` so they are not 
so specific about step indexes and the like. For "step indexes and the life" we 
should create a `ProfileStrategyTest` that does that sort of stuff as in there, 
we can only load those strategies we care about.


> LazyBarrierStrategy should not check is.testing
> -----------------------------------------------
>
>                 Key: TINKERPOP-1601
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1601
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.2.3
>            Reporter: Daniel Kuppitz
>            Assignee: Daniel Kuppitz
>
> {{LazyBarrierStrategy}} should not check the value if the system variable 
> {{is.testing}} and then behave differently depending on its value. The 
> cleaner way is to just exclude {{LBS}} in {{ProfileTest}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to