[ 
https://issues.apache.org/jira/browse/TINKERPOP-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826062#comment-15826062
 ] 

ASF GitHub Bot commented on TINKERPOP-1601:
-------------------------------------------

Github user okram commented on the issue:

    https://github.com/apache/tinkerpop/pull/535
  
    There are numerous areas where `is.testing` is used for strategies. We 
shouldn't just do this for one of them and push a PR. We should overhaul the 
entire system so we don't have some parts of the codebase using the old model 
and some parts using the new model. In fact, you should also do this for 
everywhere `is.testing` is used -- e.g. in `Translators` as well.


> LazyBarrierStrategy should not check is.testing
> -----------------------------------------------
>
>                 Key: TINKERPOP-1601
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1601
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.2.3
>            Reporter: Daniel Kuppitz
>            Assignee: Daniel Kuppitz
>
> {{LazyBarrierStrategy}} should not check the value if the system variable 
> {{is.testing}} and then behave differently depending on its value. The 
> cleaner way is to just exclude {{LBS}} in {{ProfileTest}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to