+0 If it needs to be reusable it should also work with other Application Servers (which I don't believe is possible with MP JWT Auth).
So First within TomEE and then try it to extract it and make it work elsewhere also. Rudy On 29 March 2018 at 20:21, Ivan Junckes Filho <ivanjunc...@gmail.com> wrote: > I think we should keep the code in TomEE. > > +1 > > On Thu, Mar 29, 2018 at 3:16 PM, Thiago Veronezi <thi...@veronezi.org> > wrote: > > > +1 Let's give it a shot here > > > > On Thu, Mar 29, 2018 at 2:12 PM, David Blevins <david.blev...@gmail.com> > > wrote: > > > > > I'd like to wrap this up so if you have other questions or would like > to > > > vote, now is the time. Reminder, you do not need to be a committer to > > vote. > > > > > > > > > -- > > > David Blevins > > > http://twitter.com/dblevins > > > http://www.tomitribe.com > > > > > > > On Mar 18, 2018, at 5:02 PM, David Blevins <david.blev...@gmail.com> > > > wrote: > > > > > > > > The vote for merging PR 123 does not address community will on what > to > > > do with the code beyond merging it. One can realistically vote +1 to > > merge > > > the code, but then desire to see the code cleaned up and moved > elsewhere. > > > One can realistically desire seeing an attempt to clean up the code to > > find > > > what is reusable and may wish to withhold a final decision until we see > > how > > > fruitful such a module would be. > > > > > > > > Out of respect for people who may not know exactly how they feel > (TomEE > > > or Geronimo), this is a vote for the latter. > > > > > > > > Vote: Should we attempt to extract code from the JWT PR to see what > is > > > reusable and how successful such a jar would be? > > > > > > > > +1 Let's give it a shot here > > > > +-0 > > > > -1 Let's do this elsewhere > > > > > > > > If the vote is +1 to attempt an extraction of reusable code here, > final > > > conclusion of if that extraction is worth it or where it should live is > > not > > > being voted on. People are welcome to decide differently based on the > > > results of the exercise. > > > > > > > > > > > > -David > > > > > > > > > > > > >
