Simon Laws wrote:
Use 1.0-SNAPSHOT instead of 1.4 for the travelsample version number
+1, this is separate sample so no requirement for it to be tied to the
Tuscany runtime version
Change maven repo artifact names to travelsample-xxxx
+0
>
This probably needs a bit more discussion.
At the moment many of these artifacts are being installed in my
maven repo as org/apache/tuscany/sca/tuscany-scatours-chapter-xx.
We currently use the tuscany-xxx names for maven artifacts that
are part of the Tuscany runtime, such as tuscany-assembly, etc.
It is confusing for sample artifacts to be named in the same way.
For example, for samples, itests and vtests we are using names
like sample-xxx, itest-xxx, vtest-xxx. I was proposing the name
travelsample-xxx to be consistent with this convention. The name
travelsample came from the sandbox directory in which all this
code lives.
On further investigation, I see that some of the artifacts already
have artifact names like scatours-xxx, not tuscany-scatours-xxx.
I didn't realise this when I sent my previous email. So another
way to achieve consistency would be to rename the artifacts that
are currently using tuscany-scatours-xxx names to use scatours-xxx
names. Is this a better solution?
Simon
Fix up the ant scripts that run the node launchers
+1
Change the "scatours" package names to "com.tuscanyscatours"
(I'll hold off on this for a day or two to give people a chance
to consider this and maybe make other suggestions... or offer
to help :-)
+1, happy to help but won't get round to doing anything until next
weekend. We'll have to make this consistent across the code.
Simon
