> On Jul 24, 2017, at 6:39 AM, Sam Ruby <[email protected]> wrote:
>
> On Sun, Jul 23, 2017 at 6:05 PM, Craig Russell <[email protected]> wrote:
>> How does this look?
>
> Attachment missing?
Apache policy apparently is to remove attachments. So you get it twice.
Craig
diff --git a/www/board/agenda/views/actions/todos.json.rb
b/www/board/agenda/views/actions/todos.json.rb
index 205a67e..c980c2d 100644
--- a/www/board/agenda/views/actions/todos.json.rb
+++ b/www/board/agenda/views/actions/todos.json.rb
@@ -123,6 +123,22 @@ if @establish and env.password
ASF::Committee.add(pmc.downcase, members)
end
end
+ # send out congratulations email
+ ASF::Mail.configure
+ sender = ASF::Person.new(env.user)
+ mail = Mail.new do
+ from "#{sender.public_name} <#{sender.id}@apache.org>"
+ to project.dev_mail_list()
+ cc 'Apache Board <[email protected]>'
+ subject "Congratulations to Apache Top Level Project " + project
+ body "Dear " + project + " ,\n\nAt this month's board meeting, " +
+ project + " was approved to become a top level project with " +
+ id + " as project chair. Congratulations and best wishes."
+ "\n\nWarm regards,\n\n#{sender.public_name}"
+ end
+
+ mail.deliver!
+
end
# create 'victims' file for tlpreq tool
>
>> Craig
>
> - Sam Ruby
>
>>> On Jul 23, 2017, at 8:02 AM, Craig Russell <[email protected]> wrote:
>>>
>>>>
>>>> On Jul 23, 2017, at 7:44 AM, Sam Ruby <[email protected]> wrote:
>>>>
>>>> On Sun, Jul 23, 2017 at 8:24 AM, Craig Russell <[email protected]>
>>>> wrote:
>>>>> Hi Sam,
>>>>>
>>>>> I see this code [1] in adjournment where the function launch_email_client
>>>>> is defined.
>>>>>
>>>>> What I do not see is any code that calls it.
>>>>
>>>> That code was added on the 13th:
>>>>
>>>> https://github.com/apache/whimsy/commit/3e5639264f69df53cb043d030cfa6b7e81fc8325
>>>>
>>>> And then removed a week ago, and replaced with logic on the server:
>>>>
>>>> https://github.com/apache/whimsy/commit/bb9f23f9661ae2a1e15ec1578575d6fbb974f170
>>>
>>> I missed the part about moving all of the code from whimsy-agenda to
>>> whimsy. I was looking in whimsy-agenda and it seemed to be live but I guess
>>> not so much. I wonder why the Congratulations code is in whimsy-agenda at
>>> all.
>>>>
>>>>> I also could not find how setting the variable window.location with the
>>>>> string containing the email message will do anything.
>>>>
>>>> That's a browser feature. See, for example:
>>>>
>>>> https://stackoverflow.com/questions/21461589/javascript-mailto-using-window-open
>>>
>>> That will take some time to digest.
>>>>
>>>> Launching the email from the client will require a separate action on
>>>> your part, but will give you the ability to tailor the email.
>>>>
>>>> Launching the email from the server allows greater control over
>>>> setting such things as reply-to addresses.
>>>>
>>>> In this case, I would think sending it from the server is better?
>>>
>>> Since there is nothing that needs to be tailored, I agree sending it from
>>> the server is better.
>>>
>>> Thanks,
>>>
>>> Craig
>>>
>>>>
>>>>> Thanks,
>>>>>
>>>>> Craig
>>>>
>>>> - Sam Ruby
>>>>
>>>>> [1] # launch email client, pre-filling the destination, subject, and
>>>>> body
>>>>> def launch_email_client()
>>>>> people = []
>>>>> @people.each do |person|
>>>>> people << "#{person.name} <#{person.email}>" if @checked[person.id]
>>>>> end
>>>>> destination = "mailto:#{people.join(',')}[email protected]"
>>>>>
>>>>> subject = "Congratulations on your new role at Apache"
>>>>> body = "Dear new PMC chairs,\n\nCongratulations on your new role at " +
>>>>> "Apache. I've changed your LDAP privileges to reflect your new " +
>>>>> "status.\n\nPlease read this and update the foundation records:\n" +
>>>>>
>>>>> "https://svn.apache.org/repos/private/foundation/officers/advice-for-new-pmc-chairs.txt";
>>>>> +
>>>>> "\n\nWarm regards,\n\n#{Server.username}"
>>>>>
>>>>> window.location = destination +
>>>>> "&subject=#{encodeURIComponent(subject)}" +
>>>>> "&body=#{encodeURIComponent(body)}"
>>>>> end
>>>>>
>>>>>> On Jul 23, 2017, at 7:01 AM, Sam Ruby <[email protected]> wrote:
>>>>>>
>>>>>> On Sat, Jul 22, 2017 at 5:26 PM, Craig Russell <[email protected]>
>>>>>> wrote:
>>>>>>> Ok, I give up.
>>>>>>>
>>>>>>> I found a function definition that creates an email message in a couple
>>>>>>> of places but I cannot find how it works.
>>>>>>>
>>>>>>> The function launch_email_client composes a message but I don't see how
>>>>>>> the message is sent.
>>>>>>>
>>>>>>> Perhaps the Congratulations message is just a stub and never activated?
>>>>>>
>>>>>> Most mail is constructed and sent on the server. In a few cases, mail
>>>>>> is constructed and sent on the client. In the latter case, a mailto:
>>>>>> URL is constructed, the browser is made to open that link, and that
>>>>>> opens your mail client where you can tailor the message and send it
>>>>>> yourself.
>>>>>>
>>>>>> The rest of the cases uses the mail gem:
>>>>>>
>>>>>> https://github.com/mikel/mail
>>>>>> http://www.rubydoc.info/github/mikel/mail/Mail
>>>>>>
>>>>>> This mail is sent using the deliver! method.
>>>>>>
>>>>>> Configuring mail is done using ~/.whimsy:
>>>>>> https://github.com/apache/whimsy/blob/master/MACOSX.md#configure-sending-of-mail
>>>>>>
>>>>>> Loading this configuration is done by
>>>>>> https://whimsy.apache.org/docs/api/ASF/Mail.html#method-c-configure
>>>>>>
>>>>>> A complete, standalone, example can be found here:
>>>>>>
>>>>>> https://github.com/apache/whimsy/blob/master/tools/testmail.rb
>>>>>>
>>>>>>> Craig
>>>>>>
>>>>>> - Sam Ruby
>>>>>>
>>>>>>>> On Jul 21, 2017, at 5:57 PM, Craig Russell <[email protected]>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>> I think I would be happy if only podling graduations were sent an
>>>>>>>> email.
>>>>>>>>
>>>>>>>> Why? Direct-to-TLP is not as interesting, as this is mostly a
>>>>>>>> communications exercise anyway. It's more likely that dev@podling has
>>>>>>>> more folks who are not insiders.
>>>>>>>>
>>>>>>>> Let me give this patch a try. I'll base it on the existing
>>>>>>>> congratulations on your new role.
>>>>>>>>
>>>>>>>> Craig
>>>>>>>>
>>>>>>>>> On Jul 21, 2017, at 4:08 PM, Sam Ruby <[email protected]> wrote:
>>>>>>>>>
>>>>>>>>> If it was a podling, sure:
>>>>>>>>>
>>>>>>>>> https://whimsy.apache.org/docs/api/ASF/Podling.html#method-i-dev_mail_list
>>>>>>>>>
>>>>>>>>> If it wasn't a podling previously, then perhaps not.
>>>>>>>>>
>>>>>>>>> - Sam Ruby
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Fri, Jul 21, 2017 at 4:58 PM, Craig Russell <[email protected]>
>>>>>>>>> wrote:
>>>>>>>>>> subject: Congratulations to the new Apache project %project%
>>>>>>>>>> to: %dev-list%
>>>>>>>>>> reply-to: %dev-list%
>>>>>>>>>> cc: board
>>>>>>>>>> from: %secretary%
>>>>>>>>>> body: At this month's Apache Board meeting, the board voted to
>>>>>>>>>> approve %project%
>>>>>>>>>> as a new Top Level Project with %chair% as PMC Chair.
>>>>>>>>>>
>>>>>>>>>> Best,
>>>>>>>>>>
>>>>>>>>>> %secretary%
>>>>>>>>>> Secretary, Apache Software Foundation
>>>>>>>>>>
>>>>>>>>>> I think we already know what %project% and %chair% are. But can we
>>>>>>>>>> calculate %dev-list%?
>>>>>>>>>>
>>>>>>>>>> Craig
>>>>>>>>>>
>>>>>>>>>>> On Jul 21, 2017, at 8:15 AM, Sam Ruby <[email protected]>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> On Thu, Jul 20, 2017 at 12:46 PM, Craig Russell
>>>>>>>>>>> <[email protected]> wrote:
>>>>>>>>>>>> Adjournment again.
>>>>>>>>>>>>
>>>>>>>>>>>> Change PMC chair resolutions result in sending Congratulations
>>>>>>>>>>>> message.
>>>>>>>>>>>>
>>>>>>>>>>>> Would it be possible to change the email:
>>>>>>>>>>>>
>>>>>>>>>>>> to: new-chair1, new-chair2, ... new-chair3
>>>>>>>>>>>> cc: board, pmc1, pmc2, ... pmc3
>>>>>>>>>>>>
>>>>>>>>>>>> For existing pmcs with a new chair, this acknowledges the new
>>>>>>>>>>>> chair.
>>>>>>>>>>>>
>>>>>>>>>>>> For graduating pmcs, this acknowledges their graduation.
>>>>>>>>>>>>
>>>>>>>>>>>> Should we have a different message for the two cases?
>>>>>>>>>>>>
>>>>>>>>>>>> Should we have a congratulations on graduating from the incubator?
>>>>>>>>>>>
>>>>>>>>>>> Two complicating factors, both addressable with if checks on the
>>>>>>>>>>> server and possibly new messages:
>>>>>>>>>>>
>>>>>>>>>>> 1) currently, the list is limited to, and the message focuses on,
>>>>>>>>>>> new
>>>>>>>>>>> PMC chairs, i.e., people who are now chairs but previously were not
>>>>>>>>>>> chairs of any other committee.
>>>>>>>>>>>
>>>>>>>>>>> 2) not all new committees are graduated podlings. Sometimes they
>>>>>>>>>>> form
>>>>>>>>>>> via mitosis from an existing PMC. Other times the are simply new.
>>>>>>>>>>>
>>>>>>>>>>>> Craig
>>>>>>>>>>>>
>>>>>>>>>>>> Craig L Russell
>>>>>>>>>>>> Secretary, Apache Software Foundation
>>>>>>>>>>>> [email protected] http://db.apache.org/jdo
>>>>>>>>>>>
>>>>>>>>>>> - Sam Ruby
>>>>>>>>>>
>>>>>>>>>> Craig L Russell
>>>>>>>>>> Secretary, Apache Software Foundation
>>>>>>>>>> [email protected] http://db.apache.org/jdo
>>>>>>>>>>
>>>>>>>>
>>>>>>>> Craig L Russell
>>>>>>>> Secretary, Apache Software Foundation
>>>>>>>> [email protected] http://db.apache.org/jdo
>>>>>>>>
>>>>>>>
>>>>>>> Craig L Russell
>>>>>>> Secretary, Apache Software Foundation
>>>>>>> [email protected] http://db.apache.org/jdo
>>>>>>>
>>>>>
>>>>> Craig L Russell
>>>>> Secretary, Apache Software Foundation
>>>>> [email protected] http://db.apache.org/jdo
>>>>>
>>>
>>> Craig L Russell
>>> Secretary, Apache Software Foundation
>>> [email protected] http://db.apache.org/jdo
>>
>> Craig L Russell
>> Secretary, Apache Software Foundation
>> [email protected] http://db.apache.org/jdo
>>
>>
Craig L Russell
Secretary, Apache Software Foundation
[email protected] http://db.apache.org/jdo
