kriegaex commented on PR #124: URL: https://github.com/apache/xalan-java/pull/124#issuecomment-1815631235
Throwing in a bit more opinionated talk: I dislike the practice in some OSS projects to squash multiple commits into one when merging. Firstly, if anyone looks at the merge commit, the commit message is huge and so is the code. The formerly logical separation of concerns in small commits is destroyed and therefore also the author's (or authors', if multiple developers contributed) intent. It is just like intended information hiding. Small commits are good. Squashing them unnecessarily means one big chunk of code to scroll through and process in your mind. It also makes searching for errors much harder later. If I can use `git bisect` on many small commits, I can more easily spot the commit that broke something than by finding one big commit. Moreover, it makes life harder for developers who manage multiple PRs depending on each other. In this example, if you would just have fast-forwarded my previous PR into the target branch, I would not have had to rebase, merge and force push, but this PR would just have been ready to merge as is. Please discuss this policy with your fellow Xalan developers. The practice is harmful, outdated, has no benefit whatsoever and tons of disadvantages. I could write more paragraphs, even chapters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
