vlsi commented on code in PR #124:
URL: https://github.com/apache/xalan-java/pull/124#discussion_r1396810845
##########
pom.xml:
##########
@@ -37,6 +36,32 @@
<module>distribution</module>
</modules>
+ <profiles>
+ <profile>
+ <id>jdk8</id>
+ <activation>
+ <jdk>[,9)</jdk>
+ </activation>
+ <properties>
+ <xalan.taglet.artifactId>xalan2jtaglet</xalan.taglet.artifactId>
+ </properties>
+ <modules>
+ <module>xalan2jtaglet</module>
+ </modules>
+ </profile>
+ <profile>
+ <id>jdk9+</id>
+ <activation>
+ <jdk>[9,)</jdk>
+ </activation>
+ <properties>
+ <xalan.taglet.artifactId>xalan2jtaglet_jdk9</xalan.taglet.artifactId>
+ </properties>
+ <modules>
+ <module>xalan2jtaglet_jdk9</module>
+ </modules>
+ </profile>
+ </profiles>
Review Comment:
Even though adding two profiles is not much code, I suggest just requiring
Java 17 for build, and use `--release 8`, `--target 8` to target Java 8
bytecode. It would not require profiles, it would be easier to understand.
It would be way easier to support, and it would be way fewer bugs since
javac 17 should be tested way better than javac 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org
