kriegaex commented on code in PR #124:
URL: https://github.com/apache/xalan-java/pull/124#discussion_r1398030295
##########
pom.xml:
##########
@@ -37,6 +36,32 @@
<module>distribution</module>
</modules>
+ <profiles>
+ <profile>
+ <id>jdk8</id>
+ <activation>
+ <jdk>[,9)</jdk>
+ </activation>
+ <properties>
+ <xalan.taglet.artifactId>xalan2jtaglet</xalan.taglet.artifactId>
+ </properties>
+ <modules>
+ <module>xalan2jtaglet</module>
+ </modules>
+ </profile>
+ <profile>
+ <id>jdk9+</id>
+ <activation>
+ <jdk>[9,)</jdk>
+ </activation>
+ <properties>
+ <xalan.taglet.artifactId>xalan2jtaglet_jdk9</xalan.taglet.artifactId>
+ </properties>
+ <modules>
+ <module>xalan2jtaglet_jdk9</module>
+ </modules>
+ </profile>
+ </profiles>
Review Comment:
I had discussed that with @kubycsolutions in .
I said:
>> Another question is if you really want to force every developer to run
the build on JDK 8 just because of the taglet dependencies on old `com.sun` JDK
packages, which have been superseded by others on JDK 9+. Basically, you have 3
options:
>>
>> * Continue as is.
>> * Require JDK 9+ for the build and migrate the taglet thingy to the new
API standard.
>> * Add a JDK 9+ variant of the taglet code on top of the JDK 8 version and
configure the build to use one on JDK 8 and the other on JDK 9+.
To which Joseph replied:
> Xalan currently promises to run on JRE 8. That doesn't absolutely require
that we build on JDK 8, I suppose, but I want to retain the ability to do so.
For now, that rules out requiring 9+. But we'll move forward someday.
As a first-time contributor to this project, I complied, which is the reason
why the solution looks like this and no different. Vladimir @vlsi, can you
please discuss with Joseph? My suggestion is to keep the build on JDK 8,
because all the work is done already, and I would be quite disappointed to have
invested my time just to revert most of it again now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org
