kriegaex commented on code in PR #124:
URL: https://github.com/apache/xalan-java/pull/124#discussion_r1398080087
##########
pom.xml:
##########
@@ -37,6 +36,32 @@
<module>distribution</module>
</modules>
+ <profiles>
+ <profile>
+ <id>jdk8</id>
+ <activation>
+ <jdk>[,9)</jdk>
+ </activation>
+ <properties>
+ <xalan.taglet.artifactId>xalan2jtaglet</xalan.taglet.artifactId>
+ </properties>
+ <modules>
+ <module>xalan2jtaglet</module>
+ </modules>
+ </profile>
+ <profile>
+ <id>jdk9+</id>
+ <activation>
+ <jdk>[9,)</jdk>
+ </activation>
+ <properties>
+ <xalan.taglet.artifactId>xalan2jtaglet_jdk9</xalan.taglet.artifactId>
+ </properties>
+ <modules>
+ <module>xalan2jtaglet_jdk9</module>
+ </modules>
+ </profile>
+ </profiles>
Review Comment:
> My take is that dropping JDK8 build compatibility is a separate discussion
Agreed.
> Changing the Java 8 compilation requirement -- if I'm not hallucinating
that the policy still exists
If it still exists, it is a bit weird. Java 8 is no longer supported, even
as an LTS release. I understand that Xalan should _run_ on Java 8, but where is
the value in _building_ it on Java 8? Anyway, I implemented it that way and
hope you can merge it soon. Sorry for the pressure, but I always try to
minimise the difference between touch time and cycle time in everything I do.
Frequent context changes lead to loss of efficiency. Moreover, code rots.
> If nothing else, supporting both gives us a deprecation window.
True.
> (FWIW, I'm inclined to withdraw my PR to Master/Main again. It was
originally posted for discussion; it wasn't ever ready for merge
Simply mark it as a draft PR.
> once we have it ready to consider merging, I'm tempted to reconstruct it
in proper incremental change form
That would be a total waste of time. It's what it is. _(Sorry, I watched
"The Irishman", could not resist.)_ That PR was open too long already. I
suggest focusing on getting it done, merged and leave Ant behind ASAP.
Moreover, I would not like to see my commits being redone by someone else
who is then listed as an author.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org
