jkesselm commented on code in PR #124:
URL: https://github.com/apache/xalan-java/pull/124#discussion_r1398044240
##########
pom.xml:
##########
@@ -37,6 +36,32 @@
<module>distribution</module>
</modules>
+ <profiles>
+ <profile>
+ <id>jdk8</id>
+ <activation>
+ <jdk>[,9)</jdk>
+ </activation>
+ <properties>
+ <xalan.taglet.artifactId>xalan2jtaglet</xalan.taglet.artifactId>
+ </properties>
+ <modules>
+ <module>xalan2jtaglet</module>
+ </modules>
+ </profile>
+ <profile>
+ <id>jdk9+</id>
+ <activation>
+ <jdk>[9,)</jdk>
+ </activation>
+ <properties>
+ <xalan.taglet.artifactId>xalan2jtaglet_jdk9</xalan.taglet.artifactId>
+ </properties>
+ <modules>
+ <module>xalan2jtaglet_jdk9</module>
+ </modules>
+ </profile>
+ </profiles>
Review Comment:
My take is that dropping JDK8 build compatibility is a separate discussion,
worth considering but a bit of a distraction at this moment.
Changing the Java 8 compilation requirement -- if I'm not hallucinating that
the policy still exists; remember I'm just getting back to Xalan 15 years later
and still catching up -- is something I'd want to warn our users of. If nothing
else, supporting both gives us a deprecation window.
So my take is: Valid question, open it separately as technical debt,
discuss, and deal with it as its own issue rather than here.
Other Committers may have other opinions. But I'm going to accept this into
my branch; it can always be simplified after that discussion, or folks can
throw rocks at it before merge into main if they really feel we need to delay
the already-large mvn proposal further.
(FWIW, I'm inclined to withdraw my PR to Master/Main again. It was
originally posted for discussion; it wasn't ever ready for merge and in
hindsight I should have just asked folks to review it unsquashed on the fork.
And in fact once we have it ready to consider merging, I'm tempted to
reconstruct it in proper incremental change form, thus undoing the squash and
making the actual concepts clearer in the history, at the admitted cost of
losing some history of my mistakes. Downside is my being distracted by it that
much longer. I freely admit I mis-sized the effort to learn the Maven Way.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org
