vlsi commented on PR #133: URL: https://github.com/apache/xalan-java/pull/133#issuecomment-1837058017
@kriegaex , right you are, the test will not be safe to run concurrently with the others, so you could add (`@Isolated`)[https://junit.org/junit5/docs/snapshot/api/org.junit.jupiter.api/org/junit/jupiter/api/parallel/Isolated.html] annotation to the test method so JUnit executes the test in isolation from the others. It does not hurt to have several isolated tests. As you probably want to ensure the exception is logged, you probably want adding an assertion to the test. So all-in-all it makes sense to capture the output (e.g. replace sytsem.err), assert that the output contains the expected patterns (e.g. "unable to pasre version", "xalan", ...), and mark the test as isolated. Frankly, I do not understand why you automated virtually everything yet you insist that stderr must be eyeballed. +100500 to what @jkesselm says, except "I'm probably going to come back and change it after the PR" which, in my opinion is doubtful. Of course, committers can commit code as they agree among the committers, but "dear contributor, say whatever you want in pr, but I will change it anyway" does not sound like a great practice overall. It is a tough call, and I would probably not add such a phrase. I think @jkesselm knew the exception was expected in the test, and the comment https://github.com/apache/xalan-java/pull/133#issuecomment-1836632327 was a polite variation to double-check that and note that stacktraces in console for the expected failures are confusing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
