jkesselm commented on PR #133: URL: https://github.com/apache/xalan-java/pull/133#issuecomment-1837064375
I see.... I think this is style more than substance, right now. I would have handled that exception differently in Version, which would have changed how the test behaved a bit. But I didn't write it, or write the test. This works, it's an improvement over prior state, it gets committed. Error-reporting architectural review can happen later when designing other unit tests and/or examining Xalan's progress/warning/error messages generally. Still reading the code, but currently expect to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
