[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647239#comment-13647239
 ] 

Alexander Shraer commented on ZOOKEEPER-1324:
---------------------------------------------

Hi Flavio,

All the reconfiguration-related code that was executed when a NEWLEADER message 
gets enough acks is now omitted in the patch (previously this was in 
Leader.java, tryToCommit(), the "else" clause of "if ((zxid & 0xffffffffL) != 
0)"). This is important for reconfiguration recovery - the leader discovers a 
new configuration during recovery and must apply it by executing this code. Its 
quite possible that this causes the reconfiguration recovery tests to fail.

There is a related new comment about this "if" in processAck() that I didn't 
fully understand. 

Thanks,
Alex
                
> Remove Duplicate NEWLEADER packets from the Leader to the Follower.
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1324
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1324
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: quorum
>    Affects Versions: 3.5.0
>            Reporter: Mahadev konar
>            Assignee: Thawan Kooburat
>            Priority: Critical
>             Fix For: 3.5.0, 3.4.6
>
>         Attachments: ZOOKEEPER-1324-branch-3.4.patch, ZOOKEEPER-1324.patch, 
> ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch, 
> ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to