[
https://issues.apache.org/jira/browse/ZOOKEEPER-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647411#comment-13647411
]
Alexander Shraer commented on ZOOKEEPER-1324:
---------------------------------------------
Yeah, I think German is proposing the same thing as in your link, and it seems
that its a one-line solution to the duplicate NEWLEADER problem.
A few thoughts about Thawan's comments:
I agree that it would be better not to send outstandingProposals to observers
and not to ack UPTODATE messages, but these seem like separate issues from this
JIRA's purpose.
- the following is already done in the trunk (part of ZK-107):
>1. This change also prevent the leader from counting Observer's NEWLEADER_ACK
>causing the
> quorum to form prematurely. I will submit a unit test in a separate jira
- I don't fully understand the following comment, don't think it works this way:
> 2. We are sending NEWLEADER proposal implicitly as part of sending
> outstanding proposals to
> the learners. Now you have to keep adding NEWLEADER back into outstanding
> proposals whenever > a new learner joins the quorum since it is removed
> whenever NEWLEADER packet is committed.
If I understand correctly, when a new learner joins an already established
leader we don't need to commit a NEWLEADER message, so no need to put it in
outstanding proposals.
So it seems like the main remaining motivation for this patch is decoupling the
ACK processing for NEWLEADER from the ACK processing of other messages.
> Remove Duplicate NEWLEADER packets from the Leader to the Follower.
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-1324
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1324
> Project: ZooKeeper
> Issue Type: Improvement
> Components: quorum
> Affects Versions: 3.5.0
> Reporter: Mahadev konar
> Assignee: Flavio Junqueira
> Priority: Critical
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1324-branch-3.4.patch, ZOOKEEPER-1324.patch,
> ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch,
> ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
