[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647942#comment-13647942
 ] 

Alexander Shraer commented on ZOOKEEPER-1324:
---------------------------------------------

Regarding the membership check - I think this is done here in the patch:

            if (learnerType == LearnerType.PARTICIPANT) {
                newLeaderProposal.addAck(sid);
            }

the implementation of addAck already checks that sid is a voting member of each 
required config of newLeaderProposal before counting the ack for that config. 
So the extra check above is not necessary (although it doesn't hurt).
                
> Remove Duplicate NEWLEADER packets from the Leader to the Follower.
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1324
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1324
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: quorum
>    Affects Versions: 3.5.0
>            Reporter: Mahadev konar
>            Assignee: Flavio Junqueira
>            Priority: Critical
>             Fix For: 3.5.0, 3.4.6
>
>         Attachments: ZOOKEEPER-1324-branch-3.4.patch, ZOOKEEPER-1324.patch, 
> ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch, 
> ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to