[
https://issues.apache.org/jira/browse/ZOOKEEPER-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647907#comment-13647907
]
Flavio Junqueira commented on ZOOKEEPER-1324:
---------------------------------------------
bq. I agree that it would be better not to send outstandingProposals to
observers and not to ack UPTODATE messages, but these seem like separate issues
from this JIRA's purpose.
Sure, it's a good observation, but I think we ended up not doing anything about
it, at least I can't see anything related to it in the patch.
bq. The following is already done in the trunk (part of ZK-107): 1. This change
also prevent the leader from counting Observer's NEWLEADER_ACK causing the
quorum to form prematurely. I will submit a unit test in a separate jira
This seems to be part of the merge, it would be good if you could check that it
is not conflicting with what was done in ZOOKEEPER-107.
bq. We are sending NEWLEADER proposal implicitly as part of sending outstanding
proposals to the learners. Now you have to keep adding NEWLEADER back into
outstanding proposals whenever a new learner joins the quorum since it is
removed whenever NEWLEADER packet is committed.
There was probably some confusion here, I don't think there is anything in the
patch trying to do things this way. We simply remove the line that adds
newleader to outstandingProposals.
bq. So it seems like the main remaining motivation for this patch is decoupling
the ACK processing for NEWLEADER from the ACK processing of other messages.
This is the main motivation for me.
I'll produce a new patch shortly.
> Remove Duplicate NEWLEADER packets from the Leader to the Follower.
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-1324
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1324
> Project: ZooKeeper
> Issue Type: Improvement
> Components: quorum
> Affects Versions: 3.5.0
> Reporter: Mahadev konar
> Assignee: Flavio Junqueira
> Priority: Critical
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1324-branch-3.4.patch, ZOOKEEPER-1324.patch,
> ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch,
> ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
