[
https://issues.apache.org/jira/browse/ZOOKEEPER-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647961#comment-13647961
]
Thawan Kooburat commented on ZOOKEEPER-1324:
--------------------------------------------
bq. We are sending NEWLEADER proposal implicitly as part of sending outstanding
proposals to the learners. Now you have to keep adding NEWLEADER back into
outstanding proposals whenever a new learner joins the quorum since it is
removed whenever NEWLEADER packet is committed.
This is just a response to the initial attempt to fix this bug in this patch
(https://issues.apache.org/jira/secure/attachment/12563751/ZOOKEEPER-1324.patch)
where we try to reuse processAck to collect votes for NEWLEADER_ACK.
Comments about the latest patch:
1. in 3.4 version of this patch, we have an if statement to ignore UPDATE_ACK
((zxid & 0xffffffffL) == 0) in processAck(). Looking at the code, the learner
from both 3.4 and 3.5 still sending UPTODATE_ACK, so I think we still need to
have that similar logic unless it is needed by reconfiguration.
2. (Minor) in ackSetsToString(), can you change the delimiter from ":" to ","
to match 3.4 branch?
> Remove Duplicate NEWLEADER packets from the Leader to the Follower.
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-1324
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1324
> Project: ZooKeeper
> Issue Type: Improvement
> Components: quorum
> Affects Versions: 3.5.0
> Reporter: Mahadev konar
> Assignee: Flavio Junqueira
> Priority: Critical
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1324-branch-3.4.patch, ZOOKEEPER-1324.patch,
> ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch,
> ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
