[
https://issues.apache.org/jira/browse/ZOOKEEPER-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078260#comment-14078260
]
Hongchao Deng commented on ZOOKEEPER-1993:
------------------------------------------
There is a whole bunch of changes made in this patch.
1. I did a lot of changes to the original code in QuorumPeerConfig.java as I
tried to untangle the logic a bit more. This is crucial to my current logic and
I believe it is time to do some refactoring (later refactoring is still
needed..)
2. I didn't mean to delete the entire DynamicConfigBackwardCompatibilityTest.
The original one used CRLF as line ending and git auto converted it as I
committed them.
3. The standalone logic for dynamic config is changed as folows:
1. if it's empty in zoo.cfg.dynamic, it's still standalone mode.
2. if it's not empty, not standalone mode.
3. If there are server list in both zoo.cfg and zoo.cfg.dynamic, currently
it causes unexpected errors.. It's desired to add a check.
> Keep the client port upon parsing config
> ----------------------------------------
>
> Key: ZOOKEEPER-1993
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1993
> Project: ZooKeeper
> Issue Type: Sub-task
> Affects Versions: 3.5.0
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1993.patch
>
>
> 1. Current implementation ignored and removed "clientPort" on parsing. For
> the sake of backward compatibility, "clientPort" should be kept and used upon
> parsing config on fresh boot.
> 2. When getting clientPort from both the old config and dynamic file, the one
> in dynamic file is of higher priority.
> 3. When "dynamicConfigFile" is set in zoo.cfg and not empty, standalone mode
> will be disabled.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
