[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078612#comment-14078612
 ] 

Hongchao Deng commented on ZOOKEEPER-1993:
------------------------------------------

[~shralex]
{code}
} else if ((key.startsWith("server.") || key.startsWith("group") || 
key.startsWith("weight")) && zkProp.containsKey("dynamicConfigFile"))
{ throw new ConfigException("parameter: " + key + " must be in a separate 
dynamic config file"); }
{code}
Umm.. I revisited it and think the code should be correct. Okay. I will change 
this back.

> Keep the client port upon parsing config
> ----------------------------------------
>
>                 Key: ZOOKEEPER-1993
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1993
>             Project: ZooKeeper
>          Issue Type: Sub-task
>    Affects Versions: 3.5.0
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>            Priority: Blocker
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1993.patch, ZOOKEEPER-1993.patch, 
> ZOOKEEPER-1993.patch
>
>
> 1. Current implementation ignored and removed "clientPort" on parsing. For 
> the sake of backward compatibility, "clientPort" should be kept and used upon 
> parsing config on fresh boot.
> 2. When getting clientPort from both the old config and dynamic file, the one 
> in dynamic file is of higher priority.
> 3. When "dynamicConfigFile" is set in zoo.cfg and not empty, standalone mode 
> will be disabled.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to