[
https://issues.apache.org/jira/browse/ZOOKEEPER-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078570#comment-14078570
]
Hongchao Deng commented on ZOOKEEPER-1993:
------------------------------------------
[~shralex]
Let me summarize my reasoning for it.
So most of the massive changes isn't change at all (they are putting a lot of
code into another function).
#1 Yes. Leaving client port there is just one line change. But this is very
dangerous so I force a check on client port at the end of parsing. This leads
to a few more errors being found and fixed. And most of the code changes are
not change at all. I put some code blocks into a function to reuse them.
#2 It's not. But before we get ZOOKEEPER-1995 done, it's needed.. Let's say I
start ZK server from old style config, and then I do a reconfig. There would be
two client ports. So basically I am separating what we discussed before into
three tasks to "simplify" each individual part.
#3 the check relies on the ordering of config file. It doesn't work..
> Keep the client port upon parsing config
> ----------------------------------------
>
> Key: ZOOKEEPER-1993
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1993
> Project: ZooKeeper
> Issue Type: Sub-task
> Affects Versions: 3.5.0
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1993.patch, ZOOKEEPER-1993.patch,
> ZOOKEEPER-1993.patch
>
>
> 1. Current implementation ignored and removed "clientPort" on parsing. For
> the sake of backward compatibility, "clientPort" should be kept and used upon
> parsing config on fresh boot.
> 2. When getting clientPort from both the old config and dynamic file, the one
> in dynamic file is of higher priority.
> 3. When "dynamicConfigFile" is set in zoo.cfg and not empty, standalone mode
> will be disabled.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
