[
https://issues.apache.org/jira/browse/ZOOKEEPER-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078550#comment-14078550
]
Alexander Shraer commented on ZOOKEEPER-1993:
---------------------------------------------
Hi Hongchao,
You haven't really answered my questions, so I'll try to clarify:
I may be wrong but point 1 should be a few lines of code at most.
I don't understand why Point 2 is something we'd want to do.
Point 3 in the description deserves a separate JIRA and discussion - it seems
unrelated to client ports.
Finally, a patch of this size that includes logic changes and refactoring would
be very difficult to review.
> I attach a new one which contains check for when dynamic config file is set
> server list shouldn't exist in static
> config.
There was already a check, what case did it miss ? :
} else if ((key.startsWith("server.") || key.startsWith("group") ||
key.startsWith("weight")) && zkProp.containsKey("dynamicConfigFile")) {
throw new ConfigException("parameter: " + key + " must be in a
separate dynamic config file");
}
> Keep the client port upon parsing config
> ----------------------------------------
>
> Key: ZOOKEEPER-1993
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1993
> Project: ZooKeeper
> Issue Type: Sub-task
> Affects Versions: 3.5.0
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1993.patch, ZOOKEEPER-1993.patch,
> ZOOKEEPER-1993.patch
>
>
> 1. Current implementation ignored and removed "clientPort" on parsing. For
> the sake of backward compatibility, "clientPort" should be kept and used upon
> parsing config on fresh boot.
> 2. When getting clientPort from both the old config and dynamic file, the one
> in dynamic file is of higher priority.
> 3. When "dynamicConfigFile" is set in zoo.cfg and not empty, standalone mode
> will be disabled.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
