[
https://issues.apache.org/jira/browse/ZOOKEEPER-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078308#comment-14078308
]
Hadoop QA commented on ZOOKEEPER-1993:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12658473/ZOOKEEPER-1993.patch
against trunk revision 1613553.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2241//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2241//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2241//console
This message is automatically generated.
> Keep the client port upon parsing config
> ----------------------------------------
>
> Key: ZOOKEEPER-1993
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1993
> Project: ZooKeeper
> Issue Type: Sub-task
> Affects Versions: 3.5.0
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1993.patch
>
>
> 1. Current implementation ignored and removed "clientPort" on parsing. For
> the sake of backward compatibility, "clientPort" should be kept and used upon
> parsing config on fresh boot.
> 2. When getting clientPort from both the old config and dynamic file, the one
> in dynamic file is of higher priority.
> 3. When "dynamicConfigFile" is set in zoo.cfg and not empty, standalone mode
> will be disabled.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
