Hi Guillaume, On 03/17/2010 02:03 PM, Guillaume Lerouge wrote: > Hi guys, > > while we're talking about annotations, did we ever come to an agreement > about this one?
Right now the way it's implemented is 1/, meaning: - select text - hit a shortcut (meta + M) to get the annotation create dialog - there is an explanation message in the annotations settings panel to help people discover this process. > > On Mon, Feb 8, 2010 at 5:23 PM, Jean-Vincent Drean > <[email protected]>wrote: > >> I'm +1 for 3), selecting text make a little button to appear near the >> selection. >> If it's only a small button I don't see why it would break the normal >> selection process. >> > > I still think that 3) is both the easiest to use and the option that offers > best discoverability. > > If agreed upon, can it get done before XE 2.3 final? yes I think we all agreed, more or less formal, that we want that little button next to the selection, but no, I can't commit to fixing it for 2.3 final, since the current method is "good enough" and there are other priorities (missing features vs. improvements). Thanks, Anca > > Guillaume > > Thanks, >> JV. >> >> On Tue, Feb 2, 2010 at 2:03 PM, Sergiu Dumitriu<[email protected]> wrote: >>> On 02/01/2010 12:23 PM, Ecaterina Valica wrote: >>>> IMO: >>>> >>>> There is an Add button in the Annotation Options Area. >>>> >>>> - I go to the content >>>> - I SELECT the text >>>> - I press: >>>> - OR the Add button >>>> - OR Ctrl + defined key >>>> - A popup at the selected text location appears to let me add an >> annotation. >>>> >>>> This way I can select the text without any problem in my usual >> copy/paste >>>> rutine. And when I want to add an annotation I simply click a button or >> have >>>> a key shortcut. >>> >>> +1, the annotation creation should not break the normal selection >> process. >>> >>>> I don't understand why it is necessarily to have the Ctrl activated when >> I >>>> do my selection or any other versions that appear boxes when I select >> text. >>>> >>>> 3) is ok too >>>> >>>> On Fri, Jan 29, 2010 at 18:48, Sergiu Dumitriu<[email protected]> >> wrote: >>>> >>>>> On 01/29/2010 05:39 PM, Anca Luca wrote: >>>>>> Hi Sergiu >>>>>> >>>>>> On 01/29/2010 06:28 PM, Sergiu Dumitriu wrote: >>>>>>> On 01/29/2010 03:53 PM, Anca Luca wrote: >>>>>>>> Short story: >>>>>>>> Can't use modifier keys since there is no decent cross browser >>>>> alternative. >>>>>>>> >>>>>>>> New "default" way: >>>>>>>> 1/ current solution presented at >>>>>>>> >>>>> >> http://incubator.myxwiki.org/xwiki/bin/view/Improvements/AnnotationsProposal#HAddbut >>>>>>>> with more accessible "add" button (options?) >>>>>>>> 2/ when annotations are shown simple select triggers the display of >>>>> annotation >>>>>>>> dialog >>>>>>>> 3/ simple select displays a little add icon to be clicked and >> display >>>>> the >>>>>>>> annotation dialog (1/ with button next to selection) >>>>>>>> 4/ checkbox to enable 2/ >>>>>>>> >>>>>>>> WDYT? >>>>>>>> >>>>>>>> I think I like 2 or 4. >>>>>>> >>>>>>> I prefer 3. Without a mouse it's easy to break a selection, so here >> one >>>>>>> saved click sometimes means an extra close dialog. >>>>>> >>>>>> I don't know if I understand exactly, but for me any would go, so I >>>>> registered >>>>>> your opinion. >>>>> >>>>> It's not a strong opinion, and definitely not a -1 for all the others, >>>>> just my preference. >>>>> >>>>>>> >>>>>>> But I wonder how will it be implemented, simple onmousedown/onmouseup >>>>>>> handlers?What happens if I select text using the keyboard? >>>>>> >>>>>> I can look into selection handlers, but if it takes too long, I will >> do >>>>> mouseup >>>>>> mousedown since frankly, without being disrespectful to users needs, >> I >>>>> doubt >>>>>> there would be anyone else selecting text with the keyboard. >>>>> >>>>> As long as it will be easy to change the trigger later, feel free to >>>>> take the easiest approach at the moment. >>>>> >>>>>>> What happens >>>>>>> if I select text with the mouse then adjust the selection with the >>>>> keyboard? >>>>>> >>>>>> That would be simple, I could just use whatever selection in the >> document >>>>> when >>>>>> user clicks the "add annotation" button (the form submit that is). >>>>> >>>>> Then this is good enough for my needs. >>>>> >>>>>> Thanks, >>>>>> Anca >>>>>> >>>>>>> >>>>>>>> See below for long version. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Anca >>>>>>>> >>>>>>>> On 01/29/2010 04:36 PM, Anca Luca wrote: >>>>>>>>> Hi devs, >>>>>>>>> >>>>>>>>> On 01/16/2010 09:14 PM, Anca Luca wrote: >>>>>>>>> [snip] >>>>>>>>>> * adding an annotation could be done by pushing the "add button" >> then >>>>> going in >>>>>>>>>> the content& selecting text and when the mouse is up, the >> create >>>>> window >>>>>>>>>> appears. In other words, pushing the add button would have the >> same >>>>> behaviour as >>>>>>>>>> holding the CTRL key down. Speaking of which, it seems that CTRL + >>>>> select is >>>>>>>>>> reserved in firefox for selecting a table or smth, and I also >> think >>>>> it's >>>>>>>>>> reserved to selecting full words in IEs. Could you investigate on >>>>> that and try >>>>>>>>>> to figure out what other modifier could do the job? (if a modifier >> is >>>>> required) >>>>>>>>> >>>>>>>>> I had a look at this and I have the following results: >>>>>>>>> * CTRL + select text: >>>>>>>>> - CTRL + mouse down is a shortcut for 'select full paragraph' in IE >>>>> browsers >>>>>>>>> which means it will select the entire paragraph and will be hard to >>>>> get the >>>>>>>>> selection working normally on the text you want to add annotation >> on >>>>> (it's >>>>>>>>> possible to get to a normal select mode but with some pain). I >> haven't >>>>> found a >>>>>>>>> way to prevent that behaviour >>>>>>>>> - CTRL + mouse down is a shortcut for selecting entire table cells >> in >>>>> Firefox: >>>>>>>>> cannot select only the text in a cell, by any means. I haven't >> found a >>>>> way to >>>>>>>>> prevent that behaviour >>>>>>>>> * ALT + select text: >>>>>>>>> - seems to be fine on all browsers, doesn't interfere with any >> other >>>>> reserved >>>>>>>>> keys (tested on firefox, chrome, IE) under windows, some mac BUT >>>>>>>>> - on Ubuntu, the ALT+drag combination is a system function for >> moving >>>>> windows >>>>>>>>> around on the screen. There is no way I can 'override' that from >> the >>>>> browser. >>>>>>>>> * SHIFT + select text: >>>>>>>>> - It's weird on ff and chrome since it's an accessibility shortcut >> for >>>>> selecting >>>>>>>>> text (for those who cannot drag). Namely if you hold shift while >> mouse >>>>> down, it >>>>>>>>> will select all the content from the last click you made.) >>>>>>>>> >>>>>>>>> Because of all these, I think it would be hard to rely on some >>>>> modifier key, so >>>>>>>>> we need a more accessible alternative. >>>>>>>>> >>>>>>>>> By also looking at some other annotations in other applications, I >> see >>>>> the >>>>>>>>> following options: >>>>>>>>> 1/ the alternative described at: >>>>>>>>> >>>>> >> http://incubator.myxwiki.org/xwiki/bin/view/Improvements/AnnotationsProposal#HAdd(but >>>>>>>>> which has dissappeared from the last proposal at >>>>>>>>> >>>>> >> http://incubator.myxwiki.org/xwiki/bin/download/Improvements/AnnotationsProposal/integrated.png >>>>>>>>> ), except that it should be more accessible since it would now be >> the >>>>> default >>>>>>>>> way of adding annotations. (making it visible on scroll for >> example) >>>>>>>>> 2/ while annotations are 'activated' (all or partially displayed on >>>>> the >>>>>>>>> document) simply selecting (no modifier) will trigger the >> annotation >>>>> dialog >>>>>>>>> 3/ simply selecting always displays a little icon which can be >> clicked >>>>> to open >>>>>>>>> the create dialog (for example, the way the accelerators icon is >> added >>>>> to >>>>>>>>> selected text on IE8). It would less annoy regular selection, and >> also >>>>> enable >>>>>>>>> annotations on it, but it's an extraclick to add an annotation >>>>>>>>> 4/ provide a checkbox "annotations mode", which when activated >>>>> (regardless of >>>>>>>>> whether other annotations are displayed or not), will trigger >>>>> annotation add >>>>>>>>> dialog on simple select. This solution is similar to 1/ >>>>>>>>> >>>>>>>>> WDYT? How would you see it? >>>>>>>>> >>>>>>>>> Thanks a lot, >>>>>>>>> Anca >>> >>> >>> -- >>> Sergiu Dumitriu >>> http://purl.org/net/sergiu/ >>> _______________________________________________ >>> devs mailing list >>> [email protected] >>> http://lists.xwiki.org/mailman/listinfo/devs >>> >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs >> > > > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
