On Sun, Sep 23, 2018 at 11:12 AM Vincent Massol <vinc...@massol.net> wrote:
> Hi Simon, > > > On 21 Sep 2018, at 16:58, Simon Urli <simon.u...@xwiki.com> wrote: > > > > > > > > On 9/21/18 4:53 PM, Adel Atallah wrote: > >> +1 for the warning, but I would not forbid simple users from renaming > >> or moving pages but instead just hide the action (from the page menu). > > > > OK I should have written it: by "forbid" I meant: > > > > 1. Hide the action from the menu > > 2. Return an error message if the user try to access the > renaming/moving page (using forged URL) > > > > So you suggest we shouldn't do 2? > > So +1 to prevent/warn the user when doing a move/renaming > AND copy pages containing XClass definitions FTR, copying a single page having an XClass definition is not dangerous (it won't break the application that owns the page), as it only creates a new class definition. Copying an entire application is not dangerous either. The copy won't work like the original application (this justifies a warning as it may fail the user expectations), but the original application will still work. Renaming or moving an application is dangerous as it breaks the application. > (the message should list all such pages). > > -1 to hide the action from the menu (if you’re talking about the > “Move/Rename” and “Copy" actions) because: > 1) you get to choose whether you move/rename/copy children after you click > the action > 2) even when the current page has an XClass, the user wouldn't understand > why he cannot see/click on the action. It’s better that he can do it but > get an error message, explaining why and telling him that to contact an > advanced users if he really needs to do it. > > Thanks > -Vincent > > > > >> On Fri, Sep 21, 2018 at 4:44 PM Simon Urli <simon.u...@xwiki.com> > wrote: > >>> > >>> Hi all, > >>> > >>> users might currently break their AWM application by renaming/moving > >>> pages containing XClass definition. > >>> > >>> We need a proper refactoring operation to be able to properly do such > >>> move/rename. But this feature might take a while to be completely > >>> available. > >>> > >>> In the meantime I propose that we prevent users from renaming/moving > >>> pages containing XClass. > >>> > >>> What I propose is the following: > >>> - Forbid completely *simple users* to rename/move pages containing > XClass > >>> - Display a warning to *advanced users* when they perform such > >>> operation: the same kind of warning we already have when performing > edit > >>> on XWiki pages > >>> > >>> WDYT? > >>> > >>> Simon > >>> > >>> -- > >>> Simon Urli > >>> Software Engineer at XWiki SAS > >>> simon.u...@xwiki.com > >>> More about us at http://www.xwiki.com > > > > -- > > Simon Urli > > Software Engineer at XWiki SAS > > simon.u...@xwiki.com > > More about us at http://www.xwiki.com > >
