On Wed, May 17, 2017 at 11:23 PM, Jamo Luhrsen <[email protected]> wrote:
> +1 > > On 05/17/2017 02:17 PM, Sam Hague wrote: > > +1. it is very easy to restore the patches if needed. > > > > We did something similar in NetVirt and Genius already where we > abandoned gerrits with no activity for four weeks with this > > message: "abandoned-inactivity: This gerrit was abandoned due to > inactivity for more than four weeks. Please restore when ready." > -1, personally I favour this manual review process during the weekly meeting, where committers note patches that haven't been merged, and can poke change owners, or ask someone else more recently active to have a look - or make a conscious decision to abandon such changes. In the Genius project meetings we (occasionally, not really weekly..) use a specific Gerrit query [1] I had crafted which surfaces this nicely, linked from Wiki [2]. How would this automatic abandoning of old gerrits help with migration of the identity backend? [1] https://git.opendaylight.org/gerrit/#/dashboard/?title=Genius+abandonment+review&Send+email+warning+due+to+3+weeks+inaction=project:genius+status:open+age:21d+-age:31d&Close+due+to+4+weeks+inaction=project:genius+status:open+age:31d [2] https://wiki.opendaylight.org/view/Genius:Main#Information_for_committers > > On Wed, May 17, 2017 at 5:03 PM, Anil Vishnoi <[email protected] > <mailto:[email protected]>> wrote: > > > > +1 I think we should do it. I had spent good 1 hour to look at lot > of age old openflowplugin patches to abandon them. > > > > On Wed, May 17, 2017 at 12:11 PM, Andrew Grimberg < > [email protected] <mailto:[email protected]>> > > wrote: > > > > Greetings folks, > > > > As I'm trying to figure out the logistics related to migrating > ODL from > > our current identity backend to The Linux Foundation Identity > (LFID) > > backend I've been investigating a lot of different things > related to > > Gerrit. One of the things I noticed is that we have a lot of > changes > > that are old and still open. > > > > We've got changes still open going all the way back to 2013! I > would > > like to put a proposal out that we auto-abandon changes that are > >6 > > months in age and in all honesty I would like to do it for any > change > > that is >6 weeks old but I figured that 6 months was a good > starting point. > > > > Please note that this is age of last activity, not age of > initial change > > or last patch update. So an old change that happens to have > regular use > > for some reason (such as trigger testing) via comments should > not be > > affected by this, even if they are, it's an abandon and not an > actual > > removal from the system so they won't disappear, they'll just be > removed > > from the status:open search. > > > > I'm proposing that this change happen after we finally get > Carbon out > > the door as it's going to require a restart to Gerrit to have the > > configuration updated to start this. > > > > -Andy- > > > > -- > > Andrew J Grimberg > > Lead, IT Release Engineering > > The Linux Foundation > > > > > > _______________________________________________ > > Discuss mailing list > > [email protected] <mailto:[email protected] > ight.org> > > https://lists.opendaylight.org/mailman/listinfo/discuss < > https://lists.opendaylight.org/mailman/listinfo/discuss> > > > > > > > > > > -- > > Thanks > > Anil > > > > _______________________________________________ > > Discuss mailing list > > [email protected] <mailto:[email protected] > ight.org> > > https://lists.opendaylight.org/mailman/listinfo/discuss < > https://lists.opendaylight.org/mailman/listinfo/discuss> > > > > > > > > > > _______________________________________________ > > Discuss mailing list > > [email protected] > > https://lists.opendaylight.org/mailman/listinfo/discuss > > > _______________________________________________ > Discuss mailing list > [email protected] > https://lists.opendaylight.org/mailman/listinfo/discuss >
_______________________________________________ Discuss mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/discuss
