On Tue, Feb 9, 2010 at 10:51 PM, Luke Plant <l.plant...@cantab.net> wrote: > On Tuesday 09 February 2010 02:40:03 Russell Keith-Magee wrote: > >> >> What do people think? >> > >> > Ugh. Assuming no one can come up with a brilliant fix so that the >> > auto_adapt stuff can work when combined with arbitrary other >> > decorators (I can't), I favor switching to a system that requires >> > different decorators for methods vs. functions and documenting >> > the backwards-incompatibility for 1.2. What you propose there >> > reads pretty well to me. >> >> I concur. Ugh. :-) >> >> It's not nice but given the alternatives, I think the backwards >> incompatibility is the best option. +1 to introducing method_dec >> (bikeshedding - I actually prefer method_decorator), removing >> @auto_adapt_to_method, and documenting the problem with >> user_passes_test. > > OK, good, that's what I was thinking (complete with 'ugh' reaction!). > > Now, should we backport to 1.1.X or not? We could justify *not* > backporting on the grounds that this is a fix for #12804, which does > not exist in 1.1.X. Given that no-one filed a bug about this for the > lifetime of 1.0 and 1.1, it's probably an obscure enough corner case > in the context of 1.1.X that backporting this fix will cause more harm > than good. And if someone does have a problem on 1.1.X, we can > provide a work-around (which is to use method_decorator). > > Unless anyone shouts, I'll just commit to trunk.
I'm happy to call this a "fix for @auto_adapt_to_method in 1.2", rather than a fix for the problem in 1.1. Russ %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
