On Tue, Oct 26, 2010 at 7:46 PM, Serkan Kenar <[email protected]> wrote: > Hello, > > I have created a new localflavor for Turkey and attached the sources > and documentation to the ticket #14563 (http://code.djangoproject.com/ > ticket/14563). Is it possible that this new local flavor could be > added to 1.3 release?
It's certainly possible. However, the patch still needs a little work. Firstly, the patch doesn't contain any tests for the new functionality. Localflavors have historically been light on testing, but that is a trend we should be trying to break. Confirmation of the validation algorithms underlying the new form fields work as advertised would be an absolute minimum. Tests should be added to the tests/regressiontests/forms/localflavor directory; however, if you're adding new tests, please write them as unittests, rather than doctests. Secondly, all the work should be submitted in a single patch, not multiple patches. Documentation, tests and new feature code should all be contained in a single patch file. Thirdly, the patch needs verification by a third party, preferably someone familiar with Turkish data entry requirements. This doesn't need to be anyone special or 'blessed' in the Django community - it just needs to be someone who isn't the patch author that is willing to provide an independent verification that the patch does what it says it should do. Thanks for the contribution -- if you add make these modifications, this is certainly something we can target for inclusion in 1.3. Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
