Hi Russel, On Tue, Oct 26, 2010 at 7:15 PM, Russell Keith-Magee < [email protected]> wrote:
> It's certainly possible. However, the patch still needs a little work. > Thank you for the review. I have completed the following requests, but only missing a third party confirmation. You can find the latest patch here: http://code.djangoproject.com/attachment/ticket/14563/tr-localflavor.diff . > > Firstly, the patch doesn't contain any tests for the new > functionality. Localflavors have historically been light on testing, > I have added tests for all fields. I am not so sure about how to test the province select widget, since it only gives an output. I've seen some people comparing the output of this with a text but I think that kind of testing is unnecessary. Secondly, all the work should be submitted in a single patch, not > I have attached a single patch for all code, tests and documentation. ( tr-localflavor.diff) Thirdly, the patch needs verification by a third party, preferably > I think we have to wait for somebody to raise his/her hand here. I don't know anybody else in the community who is familiar with Turkish. Best regards, -- Serkan Kenar -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
