2010/10/29 Russell Keith-Magee <[email protected]>
> python runtests.py --settings=test_sqlite forms
>
This test run without error.
1) Is the list of provinces complete and correct?
>
The list is complete and correct.
> 2) Is the use of integers the best key for this list? i.e., is there
> a better natural key, like US state abbreviations?
>
Yes. These integers are cars' license plate's first two digit in Turkey. So
if someone just see the key of the province s/he would know the province
name. (For example anyone would know that Istanbul's license plate code is
34)
> 3) Does the postal code field accurately capture all possible Turkish
> postal codes?
>
I believe it does. I don't know any condition about postal codes other than
they should be 5 digits.
> 4) Does the phone number field accurately capture all possible
> Turkish phone numbers?
>
It does. But I think it would be better to get them corrected to XXXXXXXXXX
(10 digits long, no spaces, first 3 digits are area code and the rest is
phone number) instead of 0XXX XXXXXXX.
Leading "0" is an area code and there is no need to save it to database. If
neccessary someone could write a filter to render it any way he likes.
> 5) Does the id number field accurately capture and validate all
> possible Turkish ID numbers?
>
It does. I've tested it with several real ID's.
> 6) Do the provided tests contain enough examples to validate that 3-6
> are correct?
>
Tests are ok. But phone number test could have some additional tests without
the leading zero:
self.assertEqual(f.clean("3124555678"), "0312 4555678")
self.assertEqual(f.clean("312 4555678"), "0312 4555678")
self.assertEqual(f.clean("312 455 56 78"), "0312 4555678")
Regards,
--
Ekrem SEREN
--
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en.
