On Thu, Oct 28, 2010 at 8:35 PM, Ekrem SEREN <[email protected]> wrote: > 2010/10/28 Serkan Kenar <[email protected]> >>> Thirdly, the patch needs verification by a third party, preferably >> I think we have to wait for somebody to raise his/her hand here. I don't >> know anybody else in the community who is familiar with Turkish. > > I believe I can test this. I just need a little help about the patch. > > What's the proper way to apply and test the patch?
In the root of your django source directory, run: patch -p0 < /path/to/the/patch/file.diff This will apply the patch to your Django checkout; you can then run the Django system tests; in the tests directory, run: python runtests.py --settings=test_sqlite forms See [1] for more details on running the test suite. [1] http://docs.djangoproject.com/en/dev/internals/contributing/#running-the-unit-tests This will validate that the tests run without error; however, we need more than this as part of a review. What we really need is someone with Turkish knowledge to validate that the code and tests are doing the right thing. So, in the case of this patch: 1) Is the list of provinces complete and correct? 2) Is the use of integers the best key for this list? i.e., is there a better natural key, like US state abbreviations? 3) Does the postal code field accurately capture all possible Turkish postal codes? 4) Does the phone number field accurately capture all possible Turkish phone numbers? 5) Does the id number field accurately capture and validate all possible Turkish ID numbers? 6) Do the provided tests contain enough examples to validate that 3-6 are correct? Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
