On Dec 5, 12:14 pm, Anssi Kääriäinen <anssi.kaariai...@thl.fi> wrote: > On 12/05/2011 01:41 PM, Vinay Sajip wrote:
> > The test_ticket10432 should not generate any query at all. The tests in > django/db/models/sql/where.py should ensure that in the case of empty > __in condition the query will not be executed at all (or that part of > the where condition is removed if it is possible for the query to return > rows if the __in=() executes to False). > > The problem is that the test in where.py: > if hasattr(value, '__iter__') and hasattr(value, 'next') > isn't correct. It seems that in python3 the 'next' has been renamed to > '__next__' and thus the generator will not be consumed. My python3 > knowledge is basically nonexistent, so it might be I am wrong here. Aargh, yes. You mentioned this earlier, but I missed correcting this when I did the other fixes. I've dealt with it now [basically, py3 defines 'next_name' which is 'next' on 2.x and '__next__' on 3.x - I just changed it to hasattr(value, next_name)]. > As for test running speed: how fast is it for you? For me, using an old > laptop, the speed is around 20-30 minutes (can't test for accurate speed > right now). So, if it is much slower, you have something strange in your > setup. I haven't yet run it to completion, but have just now set it up to use /dev/shm as per Florian's suggestion (as well as having fsync = off). Will report the total time once the tests have all run. Regards, Vinay Sajip -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
