Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] build: unused static symbols break compilation under Werror --
commit bc3d5c7d159a12dc8bac2f06bcc9089584cfa877 Author: Ritesh Kumar <[email protected]> phy: qcom: edp: Add Nord PHY configuration data tables This commit adds Nord-specific AUX channel, VCO divider, LDO and TX resistor calibration data. These tables are sourced from HPG Tables 2-1-a, 2-1-b and 2-1-d. > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c > b/drivers/phy/qualcomm/phy-qcom-edp.c > index 3e857d1056680..cb5f6e0ae607b 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -1741,6 +1741,39 @@ static int qcom_edp_com_configure_pll_nord(const > struct qcom_edp *edp) > return 0; > } > > +static const u8 edp_phy_aux_cfg_nord[DP_AUX_CFG_SIZE] = { > + 0x00, 0x13, 0xa4, 0x00, 0x0a, 0x26, 0x0a, 0x03, 0x37, 0x03, 0x02, 0x02, > 0x04, > +}; > + > +static const u8 edp_phy_vco_div_cfg_nord[4] = { > + 0x00, 0x00, 0x02, 0x01, > +}; [Severity: Low] Does this code introduce unused static variables? These arrays, as well as tx_res_cfg_nord below, are defined as static but are not referenced anywhere in this commit. Defining unreferenced static arrays triggers a -Wunused-const-variable compiler warning. If the kernel is built with CONFIG_WERROR=y, this warning is promoted to an error and breaks the build. While a later patch in this series (commit 1393c79f29bd788a83ce23c45373ba39e69132d0) references these tables, intermediate patches must compile cleanly to maintain git bisectability. > + > +static int qcom_edp_ldo_config_nord(const struct qcom_edp *edp) > +{ > + const struct phy_configure_opts_dp *dp_opts = &edp->dp_opts; > + > + writel(0xd0, edp->tx0 + TXn_LDO_CONFIG); [Severity: Low] Does this code introduce an unused static function? Similar to the static arrays above, qcom_edp_ldo_config_nord is defined as static but never called in this commit. This triggers a -Wunused-function warning, which will also break the build under CONFIG_WERROR=y. [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=12
