On Mon, Oct 12, 2026 at 07:02:17PM +0530, Nabige Aala wrote: > From: Ritesh Kumar <[email protected]> > > Nord relocates several DP PHY and QSERDES v8 COM registers relative > to existing SoCs.
Why? > Add Nord-specific defines for the relocated and > new-only registers in phy-qcom-qmp-qserdes-dp-com-v8.h and > phy-qcom-edp.c so Nord sequences can reference them by name. Typically we don't do it, If something differs, it should get its own set of headers, describing all necessary offsets (especially for the QSERDES). Otherwise it's not obvious if other regs (without the _NORD counterpart) are valid or not. > > Assisted-by: LLM > Signed-off-by: Ritesh Kumar <[email protected]> > Signed-off-by: Nabige Aala <[email protected]> > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 7 +++++++ > drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8.h | 3 +++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c > b/drivers/phy/qualcomm/phy-qcom-edp.c > index a3c893f72908..d5c6835b6c70 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -42,8 +42,15 @@ > #define DP_PHY_VCO_DIV 0x0074 > #define DP_PHY_TX0_TX1_LANE_CTL 0x007c > #define DP_PHY_TX2_TX3_LANE_CTL 0x00a0 > +#define DP_PHY_TX2_TX3_LANE_CTL_NORD 0x00c0 > > #define DP_PHY_STATUS 0x00e0 > +#define DP_PHY_STATUS_NORD 0x0110 > +#define DP_PHY_LDO_CFG_NORD 0x00f0 > + > +#define DP_PHY_TX_LN0_DRV_LVL_NORD 0x00e4 > +#define DP_PHY_TX_LN1_DRV_LVL_NORD 0x00e8 > +#define TXn_TX_BAND_NORD 0x0024 > > /* LANE_TXn registers */ > #define TXn_CLKBUF_ENABLE 0x0000 I'd suggest adding these together with the actual users. > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8.h > b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8.h > index 93edabb830af..008b17222a8d 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8.h > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8.h > @@ -48,5 +48,8 @@ > #define DP_QSERDES_V8_COM_CLK_FWD_CONFIG_1 0x2f4 > #define DP_QSERDES_V8_COM_CMN_STATUS 0x314 > #define DP_QSERDES_V8_COM_C_READY_STATUS 0x33c > +#define DP_QSERDES_V8_COM_SVS_MODE_CLK_SEL_NORD 0x17c > +#define DP_QSERDES_V8_COM_CMN_STATUS_NORD 0x1d0 > +#define DP_QSERDES_V8_COM_C_READY_STATUS_NORD 0x1f8 > > #endif > > -- > 2.34.1 > -- With best wishes Dmitry
