On Fri, 16 Apr 2010 21:38:06 +0200 Julien Valroff <jul...@kirya.net> wrote:
> You can check the current source packages at > http://packages.kirya.net/debian/pool/main/d/dspam/dspam_3.9.0 > +git20100416-1.debian.tar.gz > Okay. Quickly looking over the scripts (not 100% understanding how things are glued together) I have the following feedback: cron scripts for purging use additional tools that are not referenced by the Debian DSPAM package: * awk * grep * umask * rm IMHO it would be easier for you guys to use the script in the contrib directory as it does all the magic needed for maintenance (purging tokens, purging user logs, purging system logs, etc) in just one script. DSPAM build system btw needs sed in order to work. I have not seen any dependency to sed. libdspam7-drv-mysql.cron.daily could use some additional code to avoid problems if the user has added two identical entries for certain MySQL values. So just adding " | head -n 1" after awk should do the trick. The same applies to libdspam7-drv-sqlite3.cron.daily. libdspam7-drv-pgsql.cron.daily is missing. Should I code one for you? All of the scripts don't have code to run dspam_logrotate to purge the user log and the system log. IMHO that should be included into the purging scripts. Or a separate cron file could be created that just does log maintenance. README.source has a typo in it. The second title should be "b." and not "b-". Or am I missing something? Is the dspam package not missing a dependency to syslog? Is that already installed by default on Debian? File "rules" has old and not used option: --enable-signature-headers If you want to automate the creation of the splitted config files then you could use something like this: ---------------------- for foo in ExtLookup=extlookup SQLite=sqlite MySQL=mysql PostgreSQL=pgsql; do sed -n -e "/^# \-\- ${foo%=*} \-\-[\t ]*$/,/^# \-\- [^-]\{1,99\}\-\-[\t ]*$/p" src/dspam.conf.in > debian/config/${foo#*=}.conf; sed -i -e '$d' debian/config/${foo#*=}.conf; done; ---------------------- I would say that the Debian DSPAM package is in good shape. I don't see anything significantly wrong with it. btw: You can delete "006_clean-manpages.diff" as I have now updated the man pages based on the stuff you had in that diff file (with a slightly modified libdspam.3). > Cheers, > Julien > -- Kind Regards from Switzerland, Stevan Bajić ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Dspam-devel mailing list Dspam-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspam-devel
