-------- Original-Nachricht --------
> Datum: Mon, 09 Nov 2009 20:33:11 +0100
> Von: Tom Hendrikx <[email protected]>
> An: Steve <[email protected]>
> CC: [email protected]
> Betreff: Re: [Dspam-user] DSPAM 3.9.0 BETA 4
> Steve wrote:
> > Hallo Tom,
> >
> hi! :)
>
Hello,
> > I did a quick diff against my 3.9.0 Ebuild and this is the result
> > (keep in mind that my Ebuild is downloading from GIT):
> >
> There is also a git ebuild in the overlay (dspam-9999.ebuild), but its
> content is exactly the same as the beta4 one, except for the parts where
> source is retrieved (tarball vs git repo).
>
> >
> > -COMMON_DEPEND="clamav? ( app-antivirus/clamav ) -
> > ldap? ( net-nds/openldap ) +COMMON_DEPEND="clamav? (
> > >=app-antivirus/clamav-0.90.2 ) + ldap? (
> > >=net-nds/openldap-2.2 )
> >
> The mentioned versions are since long no more available on gentoo.
>
Yes. That's right. But you never know who has what version active and it's
really not needed to have a >= 2.3 dependency just because Gentoo does not
anymore have the older Ebuilds in Portage.
> > pkg_setup() {
> > + # Delete these lines some time after -r6 removal
> > + if has_version "<=mail-filter/dspam-3.8.0-r6" &&
> > <snip>
> >
> See the comment, 3.8.0-r6 is dead for ages.
>
Right. But see again my comment above.
> > + # due to parallel build failures
> > + filter-flags -j[0-9]*
> >
> This is a workaround for an already fixed bug
> (http://sourceforge.net/tracker/?func=detail&aid=2811139&group_id=250683&atid=1126467)
>
Correct.
> > +src_compile() { + emake -j1 CC="$(tc-getCC)" || die "emake
> > failed" +} +
> >
> This seems a double for above bugfix...
>
Yes. That one is fixed.
> > insinto "${DSPAM_CONFDIR}"
> > newins src/tools.pgsql_drv/pgsql_objects.sql pgsql_objects.sql &&
> > + newins src/tools.pgsql_drv/purge-pe.sql pgsql_pe-purge.sql &&
> >
> This file is dead in the beta4 and git source.
>
Nope. It's right that is not packaged in BETA4 but it's wrong regarding GIT.
The file is there and will be again included in newer versions.
> > +pkg_preinst() {
> > + # Delete these lines some time after -r6 removal
> > + if has_version "<=mail-filter/dspam-3.8.0-r6" ; then
> > <snip>
> >
> Again, see the comment.
>
> > The whole configure part needs to be changed (from my view point).
> > When I did the configure part for the stock Gentoo Ebuild (yes. I
> > have written it) then I used "[[" for most if statements. That is
> > fine but breaks on ulibc and should not be used. It's not needed.
> >
> True, consider all of [[ stuff changed.
>
Thanks.
> > The second issue is the external lookup. While you are right that
> > LDAP queries could be substituted with external lookup, it is wrong
> > to have a dependency to OpenLDAP for external lookup. The external
> > lookup module could be used WITHOUT openldap. In fact I have changed
> > the make file to search for OpenLDAP and activate LDAP functionality
> > in external lookup if it finds OpenLDAP.
> >
> 'My ebuild' is based upon the one in a sf bug [1] which is obviously
> based on he work on portage, which again is yours. IMHO the ebuild is
> far too complicated to maintain properly,
>
It's not that complicated. The whole pre-install configuration is pretty
logical. The post-install configuration is storage dependent but the flow of
the script is logical.
> so I just made sure that the
> ebuild from the bug worked for the tarballs. You're right about the ldap
> stuff, also changed that. Consider most of the other (uncommented)
> changes also applied.
>
> [1]:http://sourceforge.net/tracker/index.php?func=detail&aid=2802205&group_id=250683&atid=1126467
>
> IMHO the auto-configure stuff (emerge --config and various sed stuff
> during src_install()) should be removed from the ebuild. It would be a
> lot more useful when it is pulled out of the ebuild and into a separate
> script, that can be distributed with dspam (dspam-setup?). In stead of
> relying on USE flags as input for which backends to support, the script
> could be adapted during 'make', based on configure options.
>
I wanted to make one that uses GNU dialog to ask some questions and then based
on the responses do the whole setup/installation. But so far I had not time to
do that. But I think that something like that could be beneficial to all DSPAM
users. Unfortunately not much people invest time in helping driving DSPAM
ahead. There are many places users could help beside developing on the core of
DSPAM. I wounder why no one is doing small but important things like that?
> Maybe we can take the gentoo-specific talk off-list and try to get
> something out that we can propose to gentoo devs for portage inclusion.
> It would be nice to have beta4 as ~arch or ~arch-masked in portage.
>
Alin Năstac is probably loaded with work. Maybe if we move to RC then he could
include a Ebuild? I think if you would post an Ebuild in g.b.o then he would
add it to Portage? Should I do it?
> --
> Regards,
> Tom
>
Steve
--
GRATIS für alle GMX-Mitglieder: Die maxdome Movie-FLAT!
Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome01
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Dspam-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspam-user
